Trying to fix types in PHP Documentor comments, to help auto-complete and linters do their job#94
Merged
msyk merged 1 commit intomsyk:masterfrom Sep 4, 2024
Merged
Conversation
… and linters do their job.
Owner
|
@patacra Thanks to modify a lot of places. Now I'm working for updating for PHP 8.1 and later. Next version is going not to work on PHP7 and 8.0. |
Contributor
Author
|
@msyk with pleasure! Effectively, I imagine PHP 7 is no longer used. This means we could potentially also declare types directly in the function signatures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are certainly a lot of other places where one could improve the PHP Documentor comments, and I see how much time it takes to add/improve them. My VS Code and Sonar helps me a bit in finding things to improve.
Hope this can help a bit!
Thanks for this great lib to access FileMaker :-)